[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver
Date: Tue, 10 Jan 2017 12:01:04 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/10/2017 11:47 AM, Marc-André Lureau wrote:
> No need to allocate & copy fields, let's use static const struct
> instead.

Missing these sentences:

Add an alias field to the CharDriver structure to cover the cases where
we previously registered a driver twice under two names.  The name field
is no longer necessary, since we can now use a QAPI enum lookup.

> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---

R-by stands, just the commit message needs improvement.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]