[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/11] aspeed/smc: remove call to reset in re

From: mar.krzeminski
Subject: Re: [Qemu-devel] [PATCH v2 01/11] aspeed/smc: remove call to reset in realize function
Date: Wed, 11 Jan 2017 19:10:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

W dniu 09.01.2017 o 17:24, Cédric Le Goater pisze:
This is useless as reset will be called later on.

Signed-off-by: Cédric Le Goater <address@hidden>
Acked-by: Marcin Krzemiński <address@hidden>
  hw/ssi/aspeed_smc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 78f5aed53247..8a7217d4df6c 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -541,8 +541,6 @@ static void aspeed_smc_realize(DeviceState *dev, Error 
          sysbus_init_irq(sbd, &s->cs_lines[i]);
- aspeed_smc_reset(dev);
      /* The memory region for the controller registers */
      memory_region_init_io(&s->mmio, OBJECT(s), &aspeed_smc_ops, s,
                            s->ctrl->name, ASPEED_SMC_R_MAX * 4);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]