[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 03/25] block: Add BDS.backing_overridden

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 03/25] block: Add BDS.backing_overridden
Date: Wed, 11 Jan 2017 13:50:09 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/11/2017 12:14 PM, Max Reitz wrote:
> If the backing file is overridden, this most probably does change the
> guest-visible data of a BDS. Therefore, we will need to consider this in
> bdrv_refresh_filename().
> Adding a new field to the BDS is not nice, but it is very simple and
> exactly keeps track of whether the backing file has been overridden.
> This commit adds a FIXME which will be remedied by a follow-up commit.
> Until then, the respective piece of code will not result in any behavior
> that is worse than what we currently have.
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  include/block/block_int.h |  1 +
>  block.c                   | 13 +++++++++++++
>  block/mirror.c            |  4 ++++
>  blockdev.c                | 16 ++++++++++++++++
>  4 files changed, 34 insertions(+)

Looks like our mails crossed; I gave R-b on v3 before seeing this was
posted, and don't see any changes. To aid any automated tools:
Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]