[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1655708] Re: target/ppc/int_helper.c:2806: strange exp
[Qemu-devel] [Bug 1655708] Re: target/ppc/int_helper.c:2806: strange expression ?
Wed, 11 Jan 2017 20:09:15 -0000
> so it is just as easy to write 'i ? ...' instead of the weirder
> '(i * 2) ? ...'.
I suspect it is just possible that the i * 2 expression is a typo
for something else, perhaps i & 2 or i << 2 or i >> 2 or something else.
I don't know the code so I am unable to offer better guidance.
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
target/ppc/int_helper.c:2806: strange expression ?
Status in QEMU:
target/ppc/int_helper.c:2806:25: warning: ‘*’ in boolean context,
suggest ‘&&’ instead [-Wint-in-bool-context]
Source code is
zone_digit = (i * 2) ? b->u8[BCD_DIG_BYTE(i * 2)] >> 4 :
Which I read as
zone_digit = (i * 2) ? (b->u8[BCD_DIG_BYTE(i * 2)] >> 4) :
so I think the compiler warning is for the i * 2 lhs of the ?.
I am not sure what to suggest as a bugfix.
To manage notifications about this bug go to: