[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] [PATCH] Further tidy-up on block status
Date: Thu, 12 Jan 2017 10:05:28 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

11.01.2017 22:00, Alex Bligh wrote:
On 11 Jan 2017, at 15:31, Vladimir Sementsov-Ogievskiy <address@hidden> wrote:

If an error occurs, the server SHOULD set the appropriate error code in the 
error field of an error chunk. However, if the error does not involve invalid 
usage (such as a request beyond the bounds of the file), a server MAY reply 
with a single block status descriptor with length matching the requested 
length, and status of 0 rather than reporting the error.
- single block status descriptor for each context? Isn't it implementation 
defined? Or we finally decided to force 0 status to be safe default for all 
contexts? If it is so, it would be better to describe this separately. However, 
personally, I'd prefer to not define contexts internal semantics at all.
I think this is Wouter's wording, but I think 'a status appropriate to the 
context' would be better. Each context then needs to define what that is. 
Either that or 'the context's default status' and that should be in the 
definition of the context.

Yes this is better. But is it actually needed to force contexts have some safe default? If context wants it may define such default without this requirement.. So, should it be requirement at all?

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]