Re: [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify

[Marc-André Lureau]

Hi

----- Original Message -----
> On 01/10/2017 11:48 AM, Marc-André Lureau wrote:
> > Turn Chardev into Object.
> > 
> > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It
> > will call qemu_char_open() to open/intialize the chardev with the
> > ChardevCommon *backend settings.
> > 
> 
> > -ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
> > -                               Error **errp)
> > +static const ChardevClass *char_get_class(const char *driver, Error
> > **errp)
> > +{
> 
> Your followup "[PATCH 16/40] char: get rid of CharDriver" hoists this up
> earlier in the file. Can you minimize churn by just declaring it earlier
> to begin with?

Unless Paolo want me to respin the series, I think we will have to do with it ;)

thanks