[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv des

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling
Date: Fri, 13 Jan 2017 15:46:31 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 2017年01月13日 11:06, Peter Xu wrote:
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not
good, and we should end the day when we need to recompile the code
before getting useful debugging information for vt-d. Time to switch to
the trace system.

This is the first patch to do it.

Generally, the rule of mine is:

- for the old GENERAL typed message, I use error_report() directly if
   apply. Those are something shouldn't happen, and we should print those
   errors in all cases, even without enabling debug and tracing.

Looks like some were guest trigger-able. If yes, let's try not use error_report() for not being flooded.


- for the non-GENERAL typed messages, remove those VTD_PRINTF()s that
   looks hardly used, and convert the rest lines into trace_*().

- for useless DPRINTFs, I removed them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]