[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI br
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types |
Date: |
Fri, 13 Jan 2017 14:36:58 +0100 |
On Thu, 12 Jan 2017 19:24:46 +0100
Laszlo Ersek <address@hidden> wrote:
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
>
> Notes:
> v6:
> - rename "smi_broadcast" to "x-smi-broadcast" [Eduardo]
> - pick up Eduardo's R-b
> - pick up Michael's R-b
>
> v5:
> - replace the v4 patch "hw/i386/pc_q35: advertise broadcast SMI if VCPU
> hotplug is turned off" with a simple device property and compat
> setting [Igor]
>
> include/hw/i386/pc.h | 5 +++++
> hw/isa/lpc_ich9.c | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 230e9e70c504..9d950733abdf 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -376,6 +376,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t
> *);
>
> #define PC_COMPAT_2_8 \
> HW_COMPAT_2_8 \
> + {\
> + .driver = "ICH9-LPC",\
> + .property = "x-smi-broadcast",\
> + .value = "off",\
> + },\
>
>
> #define PC_COMPAT_2_7 \
> diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
> index ced6f803a4f2..59930dd9d09d 100644
> --- a/hw/isa/lpc_ich9.c
> +++ b/hw/isa/lpc_ich9.c
> @@ -776,6 +776,8 @@ static const VMStateDescription vmstate_ich9_lpc = {
>
> static Property ich9_lpc_properties[] = {
> DEFINE_PROP_BOOL("noreboot", ICH9LPCState, pin_strap.spkr_hi, true),
> + DEFINE_PROP_BIT64("x-smi-broadcast", ICH9LPCState, smi_host_features,
> + ICH9_LPC_SMI_F_BROADCAST_BIT, true),
> DEFINE_PROP_END_OF_LIST(),
> };
>
Reviewed-by: Igor Mammedov <address@hidden>
- [Qemu-devel] [PATCH v6 wave 2 0/3] q35: add negotiable broadcast SMI, Laszlo Ersek, 2017/01/12
- [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types, Laszlo Ersek, 2017/01/12
- Re: [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types,
Igor Mammedov <=
- [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Laszlo Ersek, 2017/01/12
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Igor Mammedov, 2017/01/13
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Laszlo Ersek, 2017/01/16
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Igor Mammedov, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Laszlo Ersek, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Igor Mammedov, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Laszlo Ersek, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Igor Mammedov, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Laszlo Ersek, 2017/01/17
- Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature, Igor Mammedov, 2017/01/18