[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notificatio

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting
Date: Fri, 13 Jan 2017 19:48:08 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/12/2017 03:46 AM, Stefan Hajnoczi wrote:
The virtio_queue_set_notification() nesting introduced for AioContext polling
raised an assertion with virtio-net (even in non-polling mode).  Converting
virtio-net and virtio-crypto to use virtio_queue_set_notification() in a
nesting fashion would be invasive and isn't worth it.

Patch 1 contains the revert to resolve the bug that Doug noticed.

Patch 2 is a less efficient but safe alternative.

Stefan Hajnoczi (2):
  Revert "virtio: turn vq->notification into a nested counter"
  virtio: disable notifications again after poll succeeded

 hw/virtio/virtio.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

Tested-by: Richard Henderson <address@hidden>

This problem affected Alpha as well.  I tested the two patches together.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]