[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count()

From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count() inlinable
Date: Sun, 15 Jan 2017 03:00:31 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Richard Henderson writes:

> On 01/13/2017 12:48 PM, Lluís Vilanova wrote:
>> uring and controlling the state of tracing events.
>> *
>> - * Copyright (C) 2011-2016 Lluís Vilanova <address@hidden>
>> + * Copyright (C) 2011-2017 Lluís Vilanova <address@hidden>
>> *
>> * This work is licensed under the terms of the GNU GPL, version 2 or later.
>> * See the COPYING file in the top-level directory.
>> @@ -237,7 +237,7 @@ char *trace_opt_parse(const char *optarg);
>> *
>> * Return the number of known vcpu-specific events
>> */
>> -uint32_t trace_get_vcpu_event_count(void);
>> +static uint32_t trace_get_vcpu_event_count(void);

> Why is this declaration still here?  It's redundant with the inline.

I can remove it if you feel strongly against it, but I kept it to maintain
consistency with the rest of the file. As I said in the previous series, this is
the style used in the header. All "public" functions (inlined or not) are
declared there with their documentation.

Being inlined is an implementation detail (inlines are defined on a separate
header), but given C's design it leaks through the static declaration.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]