Re: [Qemu-devel] [PATCH v5 3/7] qtest: Support setting named GPIOs

[Peter Maydell]

On 5 January 2017 at 04:34, Alastair D'Silva <address@hidden> wrote:
> From: Alastair D'Silva <address@hidden>
>
> Some devices change their behaviour based on the state of their input GPIO
> lines.
>
> This patch allows testing of the variable behaviour by providing facilities
> for the test to set the state of these GPIO lines.
>
> Signed-off-by: Alastair D'Silva <address@hidden>

I still think this is wrong, I'm afraid. The GPIO line is
already connected to something else in the simulation,
and injecting a value that didn't come from whatever else
it's connected to is likely to confuse things.

Tests should work by programming the device that is connected
to the other end of this GPIO to make it raise the line.

thanks
-- PMM