[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*
Date: Mon, 16 Jan 2017 18:35:55 +0000

On 11 January 2017 at 10:58, Gerd Hoffmann <address@hidden> wrote:
> No need to go the indirect route with a bitfield and mapping the bits to
> INPUT_BUTTON_*.  We can use a bool array and INPUT_BUTTON_* directly
> instead.
> Untested, not even compiled, due to lack of a osx^Wmacos machine.
> Test results are very welcome.

So what does the patch gain us? We'll now loop round
that button array for every event rather than only
the ones where the button state changed, which I
don't suppose is a big deal but does somewhat incline
me towards "just leave the code the way it is"...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]