[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 3/9] block: Avoid BlockDriverState.filename
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 3/9] block: Avoid BlockDriverState.filename |
Date: |
Mon, 16 Jan 2017 14:46:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/13/2017 02:52 PM, Max Reitz wrote:
> In places which directly pass a filename to the OS, we should not use
> the filename field at all but exact_filename instead (although the
> former currently equals the latter if that is set).
>
> In raw_open_common(), we do not need to access BDS.filename because we
> already have a local variable pointing to the filename.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 5 +++--
> block/file-posix.c | 6 +++---
> block/file-win32.c | 4 ++--
> block/gluster.c | 3 ++-
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 0/9] block: Drop BDS.filename, Max Reitz, 2017/01/13
- [Qemu-devel] [PATCH v6 1/9] block: Always set *file in get_block_status, Max Reitz, 2017/01/13
- [Qemu-devel] [PATCH v6 2/9] block: Change bdrv_get_encrypted_filename(), Max Reitz, 2017/01/13
- [Qemu-devel] [PATCH v6 4/9] block: Do not blindly copy filename from file, Max Reitz, 2017/01/13
- [Qemu-devel] [PATCH v6 3/9] block: Avoid BlockDriverState.filename, Max Reitz, 2017/01/13
- Re: [Qemu-devel] [PATCH v6 3/9] block: Avoid BlockDriverState.filename,
Eric Blake <=
- [Qemu-devel] [PATCH v6 5/9] block: Add bdrv_filename(), Max Reitz, 2017/01/13
- [Qemu-devel] [PATCH v6 9/9] iotests: Test changed Quorum filename, Max Reitz, 2017/01/16
- [Qemu-devel] [PATCH v6 8/9] block: Complete move to pull filename updates, Max Reitz, 2017/01/16
- [Qemu-devel] [PATCH v6 7/9] block: Drop BlockDriverState.filename, Max Reitz, 2017/01/16
- [Qemu-devel] [PATCH v6 6/9] qemu-img: Use bdrv_filename() for map, Max Reitz, 2017/01/16
- Re: [Qemu-devel] [PATCH v6 0/9] block: Drop BDS.filename, Max Reitz, 2017/01/16