Re: [Qemu-devel] [PATCH v2 1/6] docs: vm generation id device's description

[Eric Blake]

On 01/16/2017 02:08 PM, Ben Warren wrote:

>>>
>>> Signed-off-by: Ben Warren <address@hidden <mailto:address@hidden>>
>>> Cc: Gal Hammer <address@hidden <mailto:address@hidden>>
>>
>> If you are basing this patch off of earlier work (for example, you
>> mentioned Igor's work), you may need additional S-o-b lines for work you
>> copied from the earlier versions.
>>
> yes, I used a previous patch set as a baseline and want to make sure credit 
> goes to whoever did the real work.  In this case, Gal Hammer was the original 
> author, so I CC’d Him (or her) hoping to get an SOB.  Should that be handled 
> out-of-band?

If Gal already had S-o-b on the version you started with, then the most
common two approaches are:

1) Use Gal's commit message verbatim, including his S-o-b, then add
another paragraph about your changes, with your S-o-b.

2) Rewrite the commit message, but state that you are basing on Gal's
work, then list S-o-b for both content contributors next to one another.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature