Re: [Qemu-devel] [PULL 14/65] target-arm: Use new deposit and extract ops

[Laszlo Ersek]

On 01/14/17 21:13, Richard Henderson wrote:
> On 01/14/2017 11:41 AM, Laszlo Ersek wrote:
>> On 01/11/17 03:17, Richard Henderson wrote:
>>> Use the new primitives for UBFX and SBFX.
>>>
>>> Signed-off-by: Richard Henderson <address@hidden>
>>> ---
>>>  target/arm/translate-a64.c | 81
>>> +++++++++++++++++-----------------------------
>>>  target/arm/translate.c     | 37 +++++----------------
>>>  2 files changed, 37 insertions(+), 81 deletions(-)
>>
>> This patch causes an assertion to fail:
>>
>>> qemu-system-aarch64: .../tcg/tcg-op.c:1829: tcg_gen_deposit_z_i64:
>>> Assertion `ofs + len <= 64' failed.
>>
>> See the details below.
> 
> Please try again with
> 
>   http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg02734.html

Right, with 86c9ab277615af4e0389eb80a83073873ff96c86 (and its neighbors)
in the build, the above (very-very early) assertion is gone.

Now I'm just waiting for Stefan's "[Qemu-devel] [PATCH 0/2] virtio:
revert virtio_queue_set_notification() nesting" to hit the tree, so that
the other assertion failure (re: "vq->notification_disabled > 0")
disappears too :)

Thank you,
Laszlo