[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] COLO: Don't process failover request while
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] COLO: Don't process failover request while loading VM's state |
Date: |
Tue, 17 Jan 2017 12:24:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/17/2017 06:57 AM, zhanghailiang wrote:
> We should not do failover work while the main thread is loading
> VM's state. Otherwise the consistent of VM's memory and
> device state will be broken.
>
> We will restart the loading process after jump over the stage,
> The new failover status 'RELAUNCH' will help to record if we
> need to restart the process.
>
> Cc: Eric Blake <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Li Zhijian <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/colo.c | 26 ++++++++++++++++++++++++++
> qapi-schema.json | 4 +++-
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
> +++ b/qapi-schema.json
> @@ -856,10 +856,12 @@
> #
> # @completed: finish the process of failover
> #
> +# @relaunch: restart the failover process, from 'none' -> 'completed'
You'll need to add a '(since 2.9)' tag
> +#
> # Since: 2.8
> ##
> { 'enum': 'FailoverStatus',
> - 'data': [ 'none', 'require', 'active', 'completed'] }
> + 'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
>
> ##
> # @x-colo-lost-heartbeat:
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature