[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and fix callers |
Date: |
Wed, 18 Jan 2017 09:56:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/17/2017 07:18 AM, Cao jin wrote:
> msix_init() reports errors with error_report(), which is wrong when
> it's used in realize(). The same issue was fixed for msi_init() in
> commit 1108b2f. In order to make the API change as small as possible,
> leave the return value check to later patch.
>
> For some devices(like e1000e, vmxnet3, nvme) who won't fail because of
> msix_init's failure, suppress the error report by passing NULL error
> object.
>
> Bonus: add comment for msix_init.
>
> CC: Jiri Pirko <address@hidden>
> CC: Gerd Hoffmann <address@hidden>
> CC: Dmitry Fleytman <address@hidden>
> CC: Jason Wang <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Hannes Reinecke <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Alex Williamson <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/block/nvme.c | 2 +-
> hw/misc/ivshmem.c | 8 ++++----
> hw/net/e1000e.c | 2 +-
> hw/net/rocker/rocker.c | 4 +++-
> hw/net/vmxnet3.c | 2 +-
> hw/pci/msix.c | 36 +++++++++++++++++++++++++++++++-----
> hw/scsi/megasas.c | 4 +++-
> hw/usb/hcd-xhci.c | 4 ++--
> hw/vfio/pci.c | 8 ++++++--
> hw/virtio/virtio-pci.c | 4 ++--
> include/hw/pci/msix.h | 5 +++--
> 11 files changed, 57 insertions(+), 22 deletions(-)
>
For megasas: Reviewed-by: Hannes Reinecke <address@hidden>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
address@hidden +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH v9 10/11] msi_init: convert assert to return -errno, (continued)
[Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and fix callers, Cao jin, 2017/01/17
- Re: [Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and fix callers,
Hannes Reinecke <=
[Qemu-devel] [PATCH v9 11/11] megasas: remove unnecessary megasas_use_msix(), Cao jin, 2017/01/17
[Qemu-devel] [PATCH v9 09/11] vmxnet3: remove unnecessary internal msix flag, Cao jin, 2017/01/17
[Qemu-devel] [PATCH v9 06/11] hcd-xhci: change behaviour of msix switch, Cao jin, 2017/01/17
[Qemu-devel] [PATCH v9 07/11] megasas: undo the overwrites of msi user configuration, Cao jin, 2017/01/17
[Qemu-devel] [PATCH v9 08/11] vmxnet3: fix reference leak issue, Cao jin, 2017/01/17
Re: [Qemu-devel] [PATCH v9 00/11] Convert msix_init() to error, Michael S. Tsirkin, 2017/01/24