Re: [Qemu-devel] [PATCH 1/2] linux-user: fix settime old value location

[Peter Maydell]

On 18 January 2017 at 15:02, Pranith Kumar <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> old_value is the 4th argument of timer_settime(), not the 2nd.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Pranith Kumar <address@hidden>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 7b77503f94..5bd477a71b 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -12027,7 +12027,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>              target_to_host_itimerspec(&hspec_new, arg3);
>              ret = get_errno(
>                            timer_settime(htimer, arg2, &hspec_new, 
> &hspec_old));
> -            host_to_target_itimerspec(arg2, &hspec_old);
> +            host_to_target_itimerspec(arg4, &hspec_old);
>          }
>          break;
>      }
> --
> 2.11.0

I reviewed this when Marc sent it back in November,
but this resend doesn't seem to have addressed any
of that.

thanks
-- PMM