[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 2/2] linux-user: fix tcg/mmap test

From: Pranith Kumar
Subject: [Qemu-devel] [PATCH v3 2/2] linux-user: fix tcg/mmap test
Date: Thu, 19 Jan 2017 09:23:11 -0500

From: Marc-André Lureau <address@hidden>

tests/tcg/mmap test fails with values other than default target page
size. When creating a map beyond EOF, extra anonymous pages are added up
to the target page boundary. Currently, this operation is performed only
when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it should be
performed if the configured page size (qemu -p) is larger than
qemu_real_host_page_size too.

Signed-off-by: Marc-André Lureau <address@hidden>
[pranith: dropped checkpatch changes]
Signed-off-by: Pranith Kumar <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>

Signed-off-by: Pranith Kumar <address@hidden>
 linux-user/mmap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 61685bf79e..76905cc9fd 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -429,9 +429,9 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int 
        may need to truncate file maps at EOF and add extra anonymous pages
        up to the targets page boundary.  */
-    if ((qemu_real_host_page_size < TARGET_PAGE_SIZE)
-        && !(flags & MAP_ANONYMOUS)) {
-       struct stat sb;
+    if ((qemu_real_host_page_size < qemu_host_page_size) &&
+        !(flags & MAP_ANONYMOUS)) {
+        struct stat sb;
        if (fstat (fd, &sb) == -1)
            goto fail;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]