Re: [Qemu-devel] [PATCH v4 1/2] linux-user: fix settime old value location

[Laurent Vivier]

Le 19/01/2017 à 16:15, Pranith Kumar a écrit :
> From: Marc-André Lureau <address@hidden>
> 
> old_value is the 4th argument of timer_settime(), not the 2nd.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Pranith Kumar <address@hidden>

Reviewed-by: Laurent Vivier <address@hidden>

> ---
>  linux-user/syscall.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 7b77503f94..6666cef4ae 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -12024,10 +12024,14 @@ abi_long do_syscall(void *cpu_env, int num, 
> abi_long arg1,
>              timer_t htimer = g_posix_timers[timerid];
>              struct itimerspec hspec_new = {{0},}, hspec_old = {{0},};
>  
> -            target_to_host_itimerspec(&hspec_new, arg3);
> +            if (target_to_host_itimerspec(&hspec_new, arg3)) {
> +                goto efault;
> +            }
>              ret = get_errno(
>                            timer_settime(htimer, arg2, &hspec_new, 
> &hspec_old));
> -            host_to_target_itimerspec(arg2, &hspec_old);
> +            if (arg4 && host_to_target_itimerspec(arg4, &hspec_old)) {
> +                goto efault;
> +            }
>          }
>          break;
>      }
>