[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command m

From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command mode
Date: Thu, 19 Jan 2017 21:35:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/19/2017 08:26 PM, Peter Maydell wrote:
> On 9 January 2017 at 16:24, Cédric Le Goater <address@hidden> wrote:
>> The Aspeed SMC controllers have a mode (Command mode) in which
>> accesses to the flash content are no different than doing MMIOs. The
>> controller generates all the necessary commands to load (or store)
>> data in memory.
>> However, accesses are restricted to the segment window assigned the
>> the flash module by the controller. This window is defined by the
>> Segment Address Register.
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> Reviewed-by: Andrew Jeffery <address@hidden>
>> ---
>>  hw/ssi/aspeed_smc.c         | 152 
>> ++++++++++++++++++++++++++++++++++++++------
>>  include/hw/ssi/aspeed_smc.h |   2 +-
>>  2 files changed, 132 insertions(+), 22 deletions(-)
> This deleted the only call to aspeed_smc_is_usermode() but not
> its definition, which makes clang complain:
> /Users/pm215/src/qemu-for-merges/hw/ssi/aspeed_smc.c:409:20: error:
> unused function 'aspeed_smc_is_usermode' [-Werror,-Wunused-function]
> Presumably the function itself should be deleted?

yes. This is correct. I will send a patch for it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]