[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/4] compiler: drop ; after BUILD_BUG_ON
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/4] compiler: drop ; after BUILD_BUG_ON |
Date: |
Thu, 19 Jan 2017 15:22:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/19/2017 03:07 PM, Michael S. Tsirkin wrote:
> All users include the trailing ; anyway, let's require that -
> it seems cleaner.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> include/qemu/compiler.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
> index 157698b..7512082 100644
> --- a/include/qemu/compiler.h
> +++ b/include/qemu/compiler.h
> @@ -86,7 +86,8 @@
> #define type_check(t1,t2) ((t1*)0 - (t2*)0)
>
> #define QEMU_BUILD_BUG_ON(x) \
> - typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1]
> __attribute__((unused));
> + typedef char glue(qemu_build_bug_on__, __LINE__)[(x) ? -1 : 1] \
> + __attribute__((unused))
>
> #if defined __GNUC__
> # if !QEMU_GNUC_PREREQ(4, 4)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v3 2/4] compiler: rework BUG_ON using a struct, Dr. David Alan Gilbert, 2017/01/20