[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/12] s390x update
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PULL 00/12] s390x update |
Date: |
Fri, 20 Jan 2017 10:52:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 20.01.2017 10:21, Cornelia Huck wrote:
> On Thu, 19 Jan 2017 18:32:44 +0000
> Peter Maydell <address@hidden> wrote:
>
>> Hi; I'm afraid this fails to build on Windows:
>>
>> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c: In
>> function ‘s390_pci_get_iommu’:
>> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:415:20:
>> error: cast from pointer to integer of different size
>> [-Werror=pointer-to-int-cast]
>> uint64_t key = (unsigned long)bus;
>> ^
>> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c: In
>> function ‘s390_pci_iommu_free’:
>> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:539:20:
>> error: cast from pointer to integer of different size
>> [-Werror=pointer-to-int-cast]
>> uint64_t key = (unsigned long)bus;
>> ^
>> cc1: all warnings being treated as errors
>>
>>
>> You probably wanted uintptr_t.
>
> Fixed and v2 sent.
>
> I'm wondering if there is any way to catch this earlier (without
> actually building on Windows)? My mingw 4.8.2 cross-build worked fine...
You likely got to use the 32-bit version of MinGW (or compile with -m32
with any other version of GCC) to catch this issue, so that you get
sizeof(long) != sizeof(void *).
Thomas
- [Qemu-devel] [PULL 06/12] s390x/pci: change the device array to a list, (continued)
- [Qemu-devel] [PULL 06/12] s390x/pci: change the device array to a list, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 04/12] s390x/pci: make S390PCIIOMMU inherit Object, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 08/12] s390x/pci: PCI multibus bridge handling, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 10/12] s390x/pci: handle PCIBridge bus number, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 07/12] s390x/pci: optimize calling s390_get_phb(), Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 09/12] s390x/pci: use hashtable to look up zpci via fh, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 11/12] s390x/pci: merge msix init functions, Cornelia Huck, 2017/01/17
- [Qemu-devel] [PULL 12/12] virtio-ccw: fix ring sizing, Cornelia Huck, 2017/01/17
- Re: [Qemu-devel] [PULL 00/12] s390x update, Peter Maydell, 2017/01/19