[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] arm: stellaris: make MII accesses complete immediat

From: Peter Maydell
Subject: [Qemu-devel] [PATCH] arm: stellaris: make MII accesses complete immediately
Date: Fri, 20 Jan 2017 18:50:22 +0000

From: Michael Davidsaver <address@hidden>

When the guest attempts to start an MII register
access via the MCTL register, clear the START bit,
so that when the guest reads it back the register
transaction will be signalled as having completed.
This avoids the guest spinning as it polls the
START bit waiting for it to clear (which it
previously never would).

The  MII registers themselves still aren't implemented,
but at least we can avoid guests spending quite so much
time busy waiting.

Signed-off-by: Michael Davidsaver <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
[PMM: expand commit message]
Signed-off-by: Peter Maydell <address@hidden>
This is a minor bugfix that was lurking in Michael's
git tree from his unfinished work on a v3 of the NVIC

 hw/net/stellaris_enet.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
index 957730e..04bd10a 100644
--- a/hw/net/stellaris_enet.c
+++ b/hw/net/stellaris_enet.c
@@ -416,7 +416,10 @@ static void stellaris_enet_write(void *opaque, hwaddr 
         s->thr = value;
     case 0x20: /* MCTL */
-        s->mctl = value;
+        /* TODO: MII registers aren't modelled.
+         * Clear START, indicating that the operation completes immediately.
+         */
+        s->mctl = value & ~1;
     case 0x24: /* MDV */
         s->mdv = value;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]