[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async wo
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async work. |
Date: |
Mon, 23 Jan 2017 11:10:13 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/19/2017 09:04 AM, Alex Bennée wrote:
> +/* NOTE:
> + * If flush_global is true (the usual case), flush all tlb entries.
> + * If flush_global is false, flush (at least) all tlb entries not
> + * marked global.
> + *
> + * Since QEMU doesn't currently implement a global/not-global flag
> + * for tlb entries, at the moment tlb_flush() will also flush all
> + * tlb entries in the flush_global == false case. This is OK because
> + * CPU architectures generally permit an implementation to drop
> + * entries from the TLB at any time, so flushing more entries than
> + * required is only an efficiency issue, not a correctness issue.
> + */
> +void tlb_flush(CPUState *cpu)
> +{
Merge error re-adding the comment for flush_global?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v7 02/27] mttcg: translate-all: Enable locking debug in a debug build, (continued)
- [Qemu-devel] [PATCH v7 02/27] mttcg: translate-all: Enable locking debug in a debug build, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 10/27] tcg: enable tb_lock() for SoftMMU, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 08/27] tcg: drop global lock during TCG code execution, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 12/27] tcg: handle EXCP_ATOMIC exception for system emulation, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 11/27] tcg: enable thread-per-vCPU, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 13/27] cputlb: add assert_cpu_is_self checks, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 14/27] cputlb: tweak qemu_ram_addr_from_host_nofail reporting, Alex Bennée, 2017/01/19
- [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async work., Alex Bennée, 2017/01/19
- Re: [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async work.,
Richard Henderson <=
- [Qemu-devel] [PATCH v7 16/27] cputlb: add tlb_flush_by_mmuidx async routines, Alex Bennée, 2017/01/19
[Qemu-devel] [PATCH v7 26/27] tcg: enable MTTCG by default for ARM on x86 hosts, Alex Bennée, 2017/01/19
[Qemu-devel] [PATCH v7 18/27] cputlb: introduce tlb_flush_*_all_cpus, Alex Bennée, 2017/01/19