Re: [Qemu-devel] [PATCH 00/17] multifd v3

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH 00/17] multifd v3
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
977ae47 migration: flush receive queue
94cd0ed migration: [HACK]Transfer pages over new channels
403e546 migration: Test new fd infrastructure
1b26e24 migration: Create thread infrastructure for multifd recv side
20ead0e migration: Send the fd number which we are going to use for this page
24b9a1c migration: really use multiple pages at a time
d97ec5e migration: Create thread infrastructure for multifd send side
b2952e8 migration: create ram_multifd_page
62325d2 migration: Start of multiple fd work
8734a27 migration: create multifd migration threads
7723249 migration: Create x-multifd-group parameter
9b1abf5 migration: Create x-multifd-threads parameter
d9ec656 migration: Add multifd capability
bb058af migration: Don't create decompression threads if not enabled
3bb5588 migration: Test for disabled features on reception
cefb07a migration: create Migration Incoming State at init time
ce46b29 migration: transform remained DPRINTF into trace_

=== OUTPUT BEGIN ===
Checking PATCH 1/17: migration: transform remained DPRINTF into trace_...
Checking PATCH 2/17: migration: create Migration Incoming State at init time...
Checking PATCH 3/17: migration: Test for disabled features on reception...
Checking PATCH 4/17: migration: Don't create decompression threads if not 
enabled...
Checking PATCH 5/17: migration: Add multifd capability...
Checking PATCH 6/17: migration: Create x-multifd-threads parameter...
WARNING: line over 80 characters
#93: FILE: migration/migration.c:862:
+            (params->x_multifd_threads < 1 || params->x_multifd_threads > 
255)) {

total: 0 errors, 1 warnings, 130 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/17: migration: Create x-multifd-group parameter...
Checking PATCH 8/17: migration: create multifd migration threads...
ERROR: space required before the open brace '{'
#104: FILE: migration/ram.c:402:
+    while (!params->quit){

ERROR: trailing whitespace
#177: FILE: migration/ram.c:475:
+ $

ERROR: space required before the open brace '{'
#179: FILE: migration/ram.c:477:
+    while (!params->quit){

total: 3 errors, 0 warnings, 208 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/17: migration: Start of multiple fd work...
ERROR: space required before the open parenthesis '('
#83: FILE: migration/ram.c:467:
+        if(!multifd_send[i].c) {

ERROR: space required before the open parenthesis '('
#140: FILE: migration/ram.c:563:
+        if(!multifd_recv[i].c) {

ERROR: do not use C99 // comments
#186: FILE: migration/socket.c:50:
+    // Remove channel

ERROR: do not use C99 // comments
#203: FILE: migration/socket.c:67:
+    // Remove channel

ERROR: do not use C99 // comments
#238: FILE: migration/socket.c:209:
+//    qio_channel_close(ioc, NULL);

total: 5 errors, 0 warnings, 209 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/17: migration: create ram_multifd_page...
Checking PATCH 11/17: migration: Create thread infrastructure for multifd send 
side...
Checking PATCH 12/17: migration: really use multiple pages at a time...
ERROR: do not initialise statics to 0 or NULL
#80: FILE: migration/ram.c:531:
+    static bool once = false;

ERROR: space required before the open parenthesis '('
#102: FILE: migration/ram.c:562:
+    for(j = 0; j < pages.size; j++) {

total: 2 errors, 0 warnings, 87 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/17: migration: Send the fd number which we are going to use 
for this page...
Checking PATCH 14/17: migration: Create thread infrastructure for multifd recv 
side...
ERROR: do not initialise statics to 0 or NULL
#103: FILE: migration/ram.c:693:
+    static bool once = false;

ERROR: space required before the open parenthesis '('
#128: FILE: migration/ram.c:718:
+    for(i = 0; i < pages.num; i++) {

total: 2 errors, 0 warnings, 137 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/17: migration: Test new fd infrastructure...
ERROR: spaces required around that '=' (ctx:VxV)
#27: FILE: migration/ram.c:442:
+            for(i=0; i < num; i++) {
                  ^

ERROR: space required before the open parenthesis '('
#27: FILE: migration/ram.c:442:
+            for(i=0; i < num; i++) {

ERROR: "(foo*)" should be "(foo *)"
#31: FILE: migration/ram.c:446:
+                    != sizeof(uint8_t*)) {

ERROR: space required before the open parenthesis '('
#58: FILE: migration/ram.c:630:
+            for(i = 0; i < num; i++) {

ERROR: "(foo*)" should be "(foo *)"
#61: FILE: migration/ram.c:633:
+                                     sizeof(uint8_t*), &error_abort)

total: 5 errors, 0 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/17: migration: [HACK]Transfer pages over new channels...
Checking PATCH 17/17: migration: flush receive queue...
ERROR: trailing whitespace
#41: FILE: migration/ram.c:66:
+/* We are getting low on pages flags, so we start using combinations $

ERROR: do not initialise globals to 0 or NULL
#57: FILE: migration/ram.c:403:
+bool multifd_needs_flush = false;

ERROR: space required before the open parenthesis '('
#76: FILE: migration/ram.c:776:
+        while(!multifd_recv[i].done) {

ERROR: spaces required around that '|' (ctx:VxV)
#124: FILE: migration/ram.c:2974:
+        if ((flags & (RAM_SAVE_FLAG_MULTIFD_PAGE|RAM_SAVE_FLAG_COMPRESS))
                                                 ^

ERROR: spaces required around that '|' (ctx:VxV)
#125: FILE: migration/ram.c:2975:
+                  == (RAM_SAVE_FLAG_MULTIFD_PAGE|RAM_SAVE_FLAG_COMPRESS)) {
                                                 ^

total: 5 errors, 0 warnings, 95 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden