[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF int
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_ |
Date: |
Mon, 23 Jan 2017 20:20:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/23/2017 03:32 PM, Juan Quintela wrote:
In the subject: s/remained/remaining/
> So we can remove DPRINTF() macro
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/ram.c | 18 ++++--------------
> migration/trace-events | 4 ++++
> 2 files changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index a1c8089..ef8fadf 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -45,14 +45,6 @@
> #include "qemu/rcu_queue.h"
> #include "migration/colo.h"
>
> -#ifdef DEBUG_MIGRATION_RAM
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stdout, "migration_ram: " fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
Yay - you're getting rid of the bitrot pattern in this file!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/17] multifd v3, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_, Juan Quintela, 2017/01/23
- Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_,
Eric Blake <=
- [Qemu-devel] [PATCH 02/17] migration: create Migration Incoming State at init time, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 03/17] migration: Test for disabled features on reception, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 04/17] migration: Don't create decompression threads if not enabled, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 05/17] migration: Add multifd capability, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 06/17] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 07/17] migration: Create x-multifd-group parameter, Juan Quintela, 2017/01/23
- [Qemu-devel] [PATCH 08/17] migration: create multifd migration threads, Juan Quintela, 2017/01/23