[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/14] replay additions
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/14] replay additions |
Date: |
Mon, 23 Jan 2017 23:43:07 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v7 00/14] replay additions
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0191b3c replay: add record/replay for audio passthrough
ca532c5 audio: make audio poll timer deterministic
8690408 replay: disable default snapshot for record/replay
2d11131 blkreplay: create temporary overlay for underlaying devices
7d471b1 block: implement bdrv_snapshot_goto for blkreplay
eab8ef5 replay: save/load initial state
870fbf1 savevm: add public save_vmstate function
aff7d02 integratorcp: adding vmstate for save/restore
f604803 replay: don't use rtc clock on loadvm phase
b01b9f2 apic: save apic_delivered flag
06b4384 icount: exit cpu loop on expire
8995a01 replay: exception replay fix
1de2b63 replay: improve interrupt handling
84b9049 icount: update instruction counter on apic patching
=== OUTPUT BEGIN ===
Checking PATCH 1/14: icount: update instruction counter on apic patching...
Checking PATCH 2/14: replay: improve interrupt handling...
Checking PATCH 3/14: replay: exception replay fix...
Checking PATCH 4/14: icount: exit cpu loop on expire...
Checking PATCH 5/14: apic: save apic_delivered flag...
Checking PATCH 6/14: replay: don't use rtc clock on loadvm phase...
Checking PATCH 7/14: integratorcp: adding vmstate for save/restore...
Checking PATCH 8/14: savevm: add public save_vmstate function...
Checking PATCH 9/14: replay: save/load initial state...
Checking PATCH 10/14: block: implement bdrv_snapshot_goto for blkreplay...
Checking PATCH 11/14: blkreplay: create temporary overlay for underlaying
devices...
Checking PATCH 12/14: replay: disable default snapshot for record/replay...
Checking PATCH 13/14: audio: make audio poll timer deterministic...
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: audio/audio.c:1116:
+ timer_mod (s->ts,
total: 1 errors, 0 warnings, 12 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/14: replay: add record/replay for audio passthrough...
ERROR: space prohibited between function name and open parenthesis '('
#41: FILE: audio/audio.c:1460:
+ captured = hw->pcm_ops->run_in (hw);
total: 1 errors, 0 warnings, 190 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag, (continued)
- [Qemu-devel] [PATCH v7 06/14] replay: don't use rtc clock on loadvm phase, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 07/14] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 09/14] replay: save/load initial state, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 10/14] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 11/14] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 12/14] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 13/14] audio: make audio poll timer deterministic, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 14/14] replay: add record/replay for audio passthrough, Pavel Dovgalyuk, 2017/01/24
- Re: [Qemu-devel] [PATCH v7 00/14] replay additions,
no-reply <=
- Re: [Qemu-devel] [PATCH v7 00/14] replay additions, Paolo Bonzini, 2017/01/25