[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

From: Daniel P. Berrange
Subject: Re: [Qemu-devel] qemu-img: complains about missing iscsi option group
Date: Tue, 24 Jan 2017 11:29:46 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Tue, Jan 24, 2017 at 12:24:02PM +0100, Paolo Bonzini wrote:
> On 19/01/2017 18:03, Daniel P. Berrange wrote:
> >>> Move the iscsi option registration out of vl.c and back into a shared file
> >>> in block/ such that all programs see the options, not just the emulators.
> >> Any preference which file? It seems no other block driver registers 
> >> options.
> > ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
> > instead of just accepting all args via the -drive spec like every other
> > block driver does, so there's no precedent to follow.
> > 
> > So suggest we just need a block/iscsi-global.c to deal with this.
> Why not block/iscsi.c itself?

block/iscsi.c is a module, so not linked to qemu emulators by default.
You could still have the iscsi options in that file if you used a
conditional and built the same file twice with different content,
but it seems easier to just use a separate file

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]