[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating m

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller
Date: Tue, 24 Jan 2017 16:50:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 24/01/2017 16:05, Michael S. Tsirkin wrote:
>> So we have four cases:
>> - assign with emulated irqfd + ISR
>> - assign with emulated irqfd
>> - assign with irqfd
>> - deassign
>> Currently we don't distinguish the first two, so (which I don't like)
>> Shannon's patch ends up setting ISR twice.
> I don't see this yet - where is it set twice?

Once in virtio_notify_irqfd, once in virtio_queue_guest_notifier_read.

Unfortunately, for virtio-blk + MSI + KVM + old Windows drivers we need
the one in virtio_notify_irqfd.  For virtio-net + vhost + INTx we need
the one in virtio_queue_guest_notifier_read.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]