[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none" |
Date: |
Thu, 26 Jan 2017 12:25:24 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Thu, Jan 26, 2017 at 02:46:52PM +0530, Ashijeet Acharya wrote:
> Migration of a "none" machine with no RAM crashes abruptly as
> bitmap_new() fails and thus aborts. Instead, place a check for
> last_ram_offset() being '0' at the start of ram_save_setup() and
> error out with a meaningful error message.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> ---
> migration/ram.c | 5 +++++
> 1 file changed, 5 insertions(+)
You state the problem in the one-line Git commit summary message, it's
usually preferred to summarize the _fix_ that you're making :-). If the
below variant sounds any better, maybe the maintainer can reword it upon
applying:
migrate: Gracefully handle crash of a 'none' machine with no RAM
[...]
--
/kashyap