[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 1/5] checkpatch: add a check for utf-8 in co

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC PATCH 1/5] checkpatch: add a check for utf-8 in commit logs
Date: Mon, 30 Jan 2017 14:12:46 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Thu, Jan 26, 2017 at 02:11:01PM +0100, Thomas Huth wrote:
> This patch is a port of the following commit from the Linux kernel:
> commit 15662b3e8644905032c2e26808401a487d4e90c1
> Author: Joe Perches <address@hidden>
> Date:   Mon Oct 31 17:13:12 2011 -0700
>     checkpatch: add a --strict check for utf-8 in commit logs
>     Some find using utf-8 in commit logs inappropriate.
>     Some patch commit logs contain unintended utf-8 characters when doing
>     things like copy/pasting compilation output.
>     Look for the start of any commit log by skipping initial lines that look
>     like email headers and "From: " lines.
>     Stop looking for utf-8 at the first signature line.
>     Signed-off-by: Joe Perches <address@hidden>
>     Suggested-by: Andrew Morton <address@hidden>
>     Cc: Andy Whitcroft <address@hidden>
>     Signed-off-by: Andrew Morton <address@hidden>
>     Signed-off-by: Linus Torvalds <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  scripts/checkpatch.pl | 30 ++++++++++++++++++++++++++----
>  1 file changed, 26 insertions(+), 4 deletions(-)

This patch prevents including names with non-ASCII characters in the
commit description.  Some people care about the proper spelling of their

Allowing UTF-8 in Signed-off-by and other headers isn't enough.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]