[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] io: fix decoding when multiple websockets frame

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] io: fix decoding when multiple websockets frames arrive at once
Date: Mon, 30 Jan 2017 11:20:56 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/30/2017 04:51 AM, Daniel P. Berrange wrote:
> The qio_channel_websock_read_wire() method will read upto 4096

s/upto/up to/

> bytes off the socket and then decode the websockets header and
> payload. The code was only decoding a single websockets frame,
> even if the buffered data contained multiple frames. This meant
> that decoding of subsequent frames was delayed until further
> input arrived on the socket. This backlog of delayed frames
> gets worse & worse over time.
> Symptom was that when connecting to the VNC server via the
> built-in websockets server, mouse/keyboard interaction would
> start out fine, but slowly get more & more delayed until it
> was unusable.
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  io/channel-websock.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]