[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 06/11] ui: fix format specfier in vnc to avoid bre
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL v2 06/11] ui: fix format specfier in vnc to avoid break in build. |
Date: |
Tue, 31 Jan 2017 16:50:26 +0100 |
From: Rami Rosen <address@hidden>
When building qemu after setting _VNC_DEBUG to 1 (see ui/vnc.h),
we get the following error and the build breaks:
...
ui/vnc.c: In function ‘vnc_client_io_error’:
ui/vnc.c:1262:13: error: format ‘%d’ expects argument of type ‘int’, but
VNC_DEBUG("Closing down client sock: ret %d (%s)\n",
^
cc1: all warnings being treated as errors
make: *** [ui/vnc.o] Error 1
...
This patch solves this issue by fixing the print format specifier
in vnc_client_io_error() to be %zd, which corresponds to the type
of the "ret" variable.
Signed-off-by: Rami Rosen <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index cf9b597..6854fdb 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1257,7 +1257,7 @@ ssize_t vnc_client_io_error(VncState *vs, ssize_t ret,
Error **errp)
if (ret == 0) {
VNC_DEBUG("Closing down client sock: EOF\n");
} else if (ret != QIO_CHANNEL_ERR_BLOCK) {
- VNC_DEBUG("Closing down client sock: ret %d (%s)\n",
+ VNC_DEBUG("Closing down client sock: ret %zd (%s)\n",
ret, errp ? error_get_pretty(*errp) : "Unknown");
}
--
1.8.3.1
- Re: [Qemu-devel] [PULL v2 00/11] ui patch queue, (continued)
- [Qemu-devel] [PULL v2 00/11] ui patch queue, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 02/11] ps2: add support for mice with extra/side buttons, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 03/11] ui: add support for mice with extra/side buttons, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 01/11] qapi: add support for mice with extra/side buttons, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 11/11] console: fix console resize, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 07/11] ui/gtk.c: add ctrl-alt-= support for zoom in acceleration, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 05/11] ui/gtk: Fix mouse wheel on 3.4.0 or later, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 09/11] vnc: fix overflow in vnc_update_stats, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 10/11] gtk: Hardcode LC_CTYPE as C.utf-8, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 06/11] ui: fix format specfier in vnc to avoid break in build.,
Gerd Hoffmann <=
- [Qemu-devel] [PULL v2 04/11] vnc: track LED state separately, Gerd Hoffmann, 2017/01/31
- [Qemu-devel] [PULL v2 08/11] spice: wakeup QXL worker to pick up mouse changes, Gerd Hoffmann, 2017/01/31
- Re: [Qemu-devel] [PULL v2 00/11] ui patch queue, Peter Maydell, 2017/01/31