Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__

[Daniel P. Berrange]

On Tue, Jan 31, 2017 at 04:43:52PM +0200, Michael S. Tsirkin wrote:
> Some headers use QEMU_BUILD_BUG_ON. This causes a problem
> if the C file including that header happens to have
> QEMU_BUILD_BUG_ON at the same line number.

Do we actually hit this problem in practice ?  Even if we do hit the
problem, it surely has a trivial workaround of just inserting/removing
a blank line somewhere in the file before the QEMU_BUILD_BUG_ON.

IOW, is it really a benefit to change to use COUNTER, given that it is
less portable that what we have today ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|