qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v4 06/23] QEMU_BUILD_BUG_ON: use __COUNTER__


From: Eric Blake
Subject: Re: [Qemu-devel] [PULL v4 06/23] QEMU_BUILD_BUG_ON: use __COUNTER__
Date: Tue, 31 Jan 2017 12:52:11 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/31/2017 12:43 PM, Michael S. Tsirkin wrote:
> Some headers use QEMU_BUILD_BUG_ON. This causes a problem
> if the C file including that header happens to have
> QEMU_BUILD_BUG_ON at the same line number.
> 
> Fix using a widely available extension: __COUNTER__.
> If unavailable, provide a stub.

Uhh, this isn't the right commit message.  What happened?

> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  include/qemu/compiler.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
> index 057639a..e0ce9ff 100644
> --- a/include/qemu/compiler.h
> +++ b/include/qemu/compiler.h
> @@ -97,6 +97,9 @@
>  #define QEMU_BUILD_BUG_ON(x)
>  #endif
>  
> +#define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \
> +                                   sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)))
> +
>  #if defined __GNUC__
>  # if !QEMU_GNUC_PREREQ(4, 4)
>     /* gcc versions before 4.4.x don't support gnu_printf, so use printf. */
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]