[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 16/25] cputlb and arm/sparc targets: convert
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v9 16/25] cputlb and arm/sparc targets: convert mmuidx flushes from varg to bitmap |
Date: |
Fri, 3 Feb 2017 10:15:12 +0000 |
On 1 February 2017 at 15:05, Alex Bennée <address@hidden> wrote:
> While the vargs approach was flexible the original MTTCG ended up
> having munge the bits to a bitmap so the data could be used in
> deferred work helpers. Instead of hiding that in cputlb we push the
> change to the API to make it take a bitmap of MMU indexes instead.
>
> For ARM some the resulting flushes end up being quite long so to aid
> readability I've tended to move the index shifting to a new line so
> all the bits being or-ed together line up nicely, for example:
>
> tlb_flush_page_by_mmuidx(other_cs, pageaddr,
> (1 << ARMMMUIdx_S1SE1) |
> (1 << ARMMMUIdx_S1SE0));
>
> Signed-off-by: Alex Bennée <address@hidden>
> [AT: SPARC part only]
> Reviewed-by: Artyom Tarasenko <address@hidden>
ARM parts:
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v9 05/25] tcg: add options for enabling MTTCG, (continued)
- [Qemu-devel] [PATCH v9 05/25] tcg: add options for enabling MTTCG, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 13/25] cputlb: add assert_cpu_is_self checks, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 14/25] cputlb: tweak qemu_ram_addr_from_host_nofail reporting, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 12/25] tcg: handle EXCP_ATOMIC exception for system emulation, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 10/25] tcg: enable tb_lock() for SoftMMU, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 08/25] tcg: drop global lock during TCG code execution, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 19/25] cputlb: introduce tlb_flush_*_all_cpus[_synced], Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 16/25] cputlb and arm/sparc targets: convert mmuidx flushes from varg to bitmap, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 15/25] cputlb: introduce tlb_flush_* async work., Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 23/25] target-arm: introduce ARM_CP_EXIT_PC, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 17/25] cputlb: add tlb_flush_by_mmuidx async routines, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 24/25] target-arm: ensure all cross vCPUs TLB flushes complete, Alex Bennée, 2017/02/01
- [Qemu-devel] [PATCH v9 25/25] tcg: enable MTTCG by default for ARM on x86 hosts, Alex Bennée, 2017/02/01