[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: drop data written to a disconnected pty
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] char: drop data written to a disconnected pty |
Date: |
Mon, 6 Feb 2017 10:51:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 31/01/2017 14:45, Ed Swierk wrote:
> When a serial port writes data to a pty that's disconnected, drop the
> data and return the length dropped. This avoids triggering pointless
> retries in callers like the 16550A serial_xmit(), and causes
> qemu_chr_fe_write() to write all data to the log file, rather than
> logging only while a pty client like virsh console happens to be
> connected.
>
> Signed-off-by: Ed Swierk <address@hidden>
> ---
> qemu-char.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 676944a..ccb6923 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1528,7 +1528,7 @@ static int pty_chr_write(CharDriverState *chr, const
> uint8_t *buf, int len)
> /* guest sends data, check for (re-)connect */
> pty_chr_update_read_handler_locked(chr);
> if (!s->connected) {
> - return 0;
> + return len;
> }
> }
> return io_channel_send(s->ioc, buf, len);
>
Rebased and queued, thanks.
Paolo