[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 15/16] postcopy: Check for userfault+hugepage fea
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v2 15/16] postcopy: Check for userfault+hugepage feature |
Date: |
Mon, 6 Feb 2017 17:33:05 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
We need extra Linux kernel support (~4.11) to support userfaults
on hugetlbfs; check for them.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
---
migration/postcopy-ram.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 6b30b43..102fb61 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -81,6 +81,17 @@ static bool ufd_version_check(int ufd)
return false;
}
+ if (getpagesize() != ram_pagesize_summary()) {
+ bool have_hp = false;
+ /* We've got a huge page */
+#ifdef UFFD_FEATURE_MISSING_HUGETLBFS
+ have_hp = api_struct.features & UFFD_FEATURE_MISSING_HUGETLBFS;
+#endif
+ if (!have_hp) {
+ error_report("Userfault on this host does not support huge pages");
+ return false;
+ }
+ }
return true;
}
@@ -115,7 +126,6 @@ bool postcopy_ram_supported_by_host(void)
if (!ufd_version_check(ufd)) {
goto out;
}
- /* TODO: Only allow huge pages if the kernel supports it */
/*
* userfault and mlock don't go together; we'll put it back later if
--
2.9.3
- [Qemu-devel] [PATCH v2 14/16] postcopy: Update userfaultfd.h header, (continued)
- [Qemu-devel] [PATCH v2 14/16] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/02/06
- [Qemu-devel] [PATCH v2 12/16] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/02/06
- [Qemu-devel] [PATCH v2 16/16] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/02/06
- [Qemu-devel] [PATCH v2 10/16] postcopy: Load huge pages in one go, Dr. David Alan Gilbert (git), 2017/02/06
- [Qemu-devel] [PATCH v2 15/16] postcopy: Check for userfault+hugepage feature,
Dr. David Alan Gilbert (git) <=
- Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support, Dr. David Alan Gilbert, 2017/02/06
- Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support, Dr. David Alan Gilbert, 2017/02/13