[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/5] target/hppa patch queue
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PULL 0/5] target/hppa patch queue |
Date: |
Mon, 6 Feb 2017 18:42:54 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL 0/5] target/hppa patch queue
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ce2db6b target/hppa: Fix gdb_write_register
dfb4b9c target/hppa: Tidy do_cbranch
b17ea53 linux-user: define correct UTS machine name for hppa
84e4ae2 linux-user: fix "apt-get update" on linux-user hppa
a2cb156 linux-user: add hppa magic numbers in qemu-binfmt-conf.sh
=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-user: add hppa magic numbers in qemu-binfmt-conf.sh...
ERROR: line over 90 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:95:
+hppa_magic='\x7f\x45\x4c\x46\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x0f'
ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:96:
+hppa_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
total: 2 errors, 0 warnings, 22 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: linux-user: fix "apt-get update" on linux-user hppa...
Checking PATCH 3/5: linux-user: define correct UTS machine name for hppa...
Checking PATCH 4/5: target/hppa: Tidy do_cbranch...
Checking PATCH 5/5: target/hppa: Fix gdb_write_register...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PULL 0/5] target/hppa patch queue, Richard Henderson, 2017/02/06
- [Qemu-devel] [PULL 1/5] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh, Richard Henderson, 2017/02/06
- [Qemu-devel] [PULL 2/5] linux-user: fix "apt-get update" on linux-user hppa, Richard Henderson, 2017/02/06
- [Qemu-devel] [PULL 3/5] linux-user: define correct UTS machine name for hppa, Richard Henderson, 2017/02/06
- [Qemu-devel] [PULL 4/5] target/hppa: Tidy do_cbranch, Richard Henderson, 2017/02/06
- [Qemu-devel] [PULL 5/5] target/hppa: Fix gdb_write_register, Richard Henderson, 2017/02/06
- Re: [Qemu-devel] [PULL 0/5] target/hppa patch queue,
no-reply <=
- Re: [Qemu-devel] [PULL 0/5] target/hppa patch queue, Peter Maydell, 2017/02/07