[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context in
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context invalidate |
Date: |
Tue, 7 Feb 2017 16:12:33 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Feb 07, 2017 at 02:16:15PM +0800, Jason Wang wrote:
>
>
> On 2017年02月03日 16:22, Peter Xu wrote:
> >Before this one we only invalidate context cache when we receive context
> >entry invalidations. However it's possible that the invalidation also
> >contains a domain switch (only if cache-mode is enabled for vIOMMU). In
> >that case we need to notify all the registered components about the new
> >mapping.
> >
> >Signed-off-by: Peter Xu <address@hidden>
> >---
> > hw/i386/intel_iommu.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> >diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> >index 0a42c01..363227d 100644
> >--- a/hw/i386/intel_iommu.c
> >+++ b/hw/i386/intel_iommu.c
> >@@ -1115,6 +1115,16 @@ static void
> >vtd_context_device_invalidate(IntelIOMMUState *s,
> > trace_vtd_inv_desc_cc_device(bus_n, VTD_PCI_SLOT(devfn_it),
> > VTD_PCI_FUNC(devfn_it));
> > vtd_as->context_cache_entry.context_cache_gen = 0;
> >+ /*
> >+ * So a device is moving out of (or moving into) a
> >+ * domain, a replay() suites here to notify all the
> >+ * IOMMU_NOTIFIER_MAP registers about this change.
> >+ * This won't bring bad even if we have no such
> >+ * notifier registered - the IOMMU notification
> >+ * framework will skip MAP notifications if that
> >+ * happened.
> >+ */
> >+ memory_region_iommu_replay_all(&vtd_as->iommu);
> > }
> > }
> > }
>
> Reviewed-by: Jason Wang <address@hidden>
>
> We may consider to squash this into patch 18.
I can do it. Thanks,
-- peterx
- Re: [Qemu-devel] [PATCH v6 10/18] memory: add section range info for IOMMU notifier, (continued)
- [Qemu-devel] [PATCH v6 11/18] memory: provide IOMMU_NOTIFIER_FOREACH macro, Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 12/18] memory: provide iommu_replay_all(), Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 13/18] memory: introduce memory_region_notify_one(), Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 14/18] memory: add MemoryRegionIOMMUOps.replay() callback, Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 15/18] intel_iommu: provide its own replay() callback, Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context invalidate, Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 17/18] intel_iommu: allow dynamic switch of IOMMU region, Peter Xu, 2017/02/03
- [Qemu-devel] [PATCH v6 18/18] intel_iommu: enable vfio devices, Peter Xu, 2017/02/03