[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration
From: |
Andrea Bolognani |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files |
Date: |
Wed, 08 Feb 2017 19:49:16 +0100 |
On Wed, 2017-02-08 at 19:11 +0100, Laszlo Ersek wrote:
> How about:
>
> For any new guest, its permanent, private variable store should
> initially be copied from the template file provided as part of the
> ArmVirtQemu firmware platform (which is occasionally distributed
> under the AAVMF package).
The naming is confusing enough as it is, no need to drag
ArmVirtQemu into this I think ;)
> > +# Fedora:
> > +# /usr/share/edk2/aarch64/QEMU_EFI.fd
> > +# /usr/share/edk2/aarch64/QEMU_VARS.fd
>
> Please annotate each as firmware binary & variable store template.
I had such annotations at some points, I got rid of them
because they seemed a bit redundant. Added them back in.
> Also, I can't verify the exact pathnames for Fedora.
https://koji.fedoraproject.org/koji/rpminfo?rpmID=8491933 ;)
[...]
> > +# RHEL:
> > +# /usr/share/AAVMF/AAVMF_CODE.fd
> > +# /usr/share/AAVMF/AAVMF_VARS.fd
>
> Looks legit. (Might want to call "RHEL" "RHELSA" though, in this context
> -- no clue. Ask Drew :))
Yeah, you're probably right.
[...]
> Please expand the comment:
>
> CHANGE ME TO THE NAME OF THE FILE THAT YOU CREATED AS A COPY of THE
> VARSTORE TEMPLATE
Nope. The line would get waaay too long, and I trust the
user to understand the basic idea after having gone through
the paragraphs above.
Here's an updated version, what do you think about it?
# Firmware configuration
# =========================================================
#
# There are two parts to the firmware: a read-only image
# containing the executable code, which is shared between
# guests, and a read/write variable store that is owned
# by one specific guest, exclusively, and is used to record
# information such as the UEFI boot order.
#
# For any new guest, its permanent, private variable store
# should initially be copied from the template file
# provided along with the firmware binary.
#
# Depending on the OS distribution you're using on the
# host, the name of the package containing the firmware
# binary and variable store, as well as the paths to the
# files themselves, will be different. Some examples:
#
# Fedora:
# edk2-aarch64 (package)
# /usr/share/edk2/aarch64/QEMU_EFI.fd (binary)
# /usr/share/edk2/aarch64/QEMU_VARS.fd (template)
#
# RHELSA:
# AAVMF (package)
# /usr/share/AAVMF/AAVMF_CODE.fd (binary)
# /usr/share/AAVMF/AAVMF_VARS.fd (varstore)
--
Andrea Bolognani / Red Hat / Virtualization
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files, Peter Maydell, 2017/02/08
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files, Andrea Bolognani, 2017/02/08
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files, Peter Maydell, 2017/02/08
Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files, Laszlo Ersek, 2017/02/08