[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a
Re: [Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a flat union
Wed, 8 Feb 2017 13:21:22 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
On 02/08/2017 10:04 AM, Markus Armbruster wrote:
> Simple unions are simpler than flat unions in the schema, but more
> complicated in C and on the QMP wire: there's extra indirection in C
> and extra nesting on the wire, both pointless. They're best avoided
> in new code.
> NumaOptions isn't new, but it's only used internally, not in QMP.
> Convert it to a flat union.
> Signed-off-by: Markus Armbruster <address@hidden>
> numa.c | 4 ++--
> qapi-schema.json | 8 ++++++++
> 2 files changed, 10 insertions(+), 2 deletions(-)
> +++ b/qapi-schema.json
> @@ -5545,6 +5545,12 @@
> 'events' : [ 'InputEvent' ] } }
> +# @NumaOptionsType:
Do we want a 'Since: 2.1' designation (since the enum has effectively
existed, even if implicitly, for as long as NumaOptions has been around)?
With or without that extra line,
Reviewed-by: Eric Blake <address@hidden>
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature