[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/17] migration: Create x-multifd-threads param
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 06/17] migration: Create x-multifd-threads parameter |
Date: |
Thu, 09 Feb 2017 18:28:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> wrote:
> On 01/23/2017 03:32 PM, Juan Quintela wrote:
>> Indicates the number of threads that we would create. By default we
>> create 2 threads.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> ---
>
>> +++ b/qapi-schema.json
>> @@ -981,13 +981,17 @@
>> # @x-checkpoint-delay: The delay time (in ms) between two COLO checkpoints
>> in
>> # periodic mode. (Since 2.8)
>> #
>> +# @x-multifd-threads: Number of threads used to migrate data in parallel
>> +# The default value is 2 (since 2.9)
>
>
>> +#
>> +# @x-multifd-threads: Number of threads used to migrate data in parallel
>> +# The default value is 1 (since 2.9)
>
> So which is it? I understand why you document it twice (one for setting
> the value, and one for listing the current setting), but not why you
> have two different defaults.
Because of copy & paste, and only updating one of the places.
Move both of them to 2.
Thanks, Juan.