[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift chec
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level |
Date: |
Fri, 10 Feb 2017 12:20:58 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Feb 07, 2017 at 04:28:11PM +0800, Peter Xu wrote:
> This helps in debugging incorrect level passed in.
>
> Reviewed-by: Jason Wang <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/i386/intel_iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index ad304f6..22d8226 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -168,6 +168,7 @@ static gboolean vtd_hash_remove_by_domain(gpointer key,
> gpointer value,
> /* The shift of an addr for a certain level of paging structure */
> static inline uint32_t vtd_slpt_level_shift(uint32_t level)
> {
> + assert(level != 0);
> return VTD_PAGE_SHIFT_4K + (level - 1) * VTD_SL_LEVEL_BITS;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v7 04/17] intel_iommu: add "caching-mode" option, (continued)
- [Qemu-devel] [PATCH v7 06/17] intel_iommu: renaming gpa to iova where proper, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 07/17] intel_iommu: convert dbg macros to traces for inv, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 08/17] intel_iommu: convert dbg macros to trace for trans, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level, Peter Xu, 2017/02/07
- Re: [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level,
David Gibson <=
- [Qemu-devel] [PATCH v7 10/17] memory: add section range info for IOMMU notifier, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 11/17] memory: provide IOMMU_NOTIFIER_FOREACH macro, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 12/17] memory: provide iommu_replay_all(), Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 13/17] memory: introduce memory_region_notify_one(), Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback, Peter Xu, 2017/02/07