Re: [Qemu-devel] [PATCH 0/3] COLO: fix some bugs

[Hailiang Zhang]

On 2017/2/10 23:44, Dr. David Alan Gilbert wrote:
> * zhanghailiang (address@hidden) wrote:
> > Hi,
> >
> > This series fix three bugs of COLO.
> > patch 1 fix one usage case which users want to change checkpoint-delay
> > with an extream big value set before, the new value may not take effect
> > until finishing a long time of sleep.
> >
> > Patch 2 and 3 are old patches that split from previous version
> > long time ago, and has been reviewed by Dave.
> >
> > I'd like to pick these three patches from the later COLO series,
> > which will include some optimization and integrating with block
> > replication and COLO net proxy.
> >
> > Please review, thanks.
>
> Queued.
> I've added the '(Since 2.9)' that Eric asked for.

Thank you very much.
By the way, as we discussed in patch 1, should i add the codes in patch 1
which kick the colo_checkpoint_sem to quick the colo thread exiting ?
In next version ? Or post a new patch ?

Hailiang


> Dave
>
> > zhanghailiang (3):
> >    COLO: fix setting checkpoint-delay not working properly
> >    COLO: Shutdown related socket fd while do failover
> >    COLO: Don't process failover request while loading VM's state
> >
> >   include/migration/colo.h      |   2 +
> >   include/migration/migration.h |   8 ++++
> >   migration/colo.c              | 102 +++++++++++++++++++++++++++++++++++++-----
> >   migration/migration.c         |   3 ++
> >   qapi-schema.json              |   4 +-
> >   5 files changed, 108 insertions(+), 11 deletions(-)
> >
> > --
> > 1.8.3.1
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
> .