[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/4] hw/arm/integrator: Use new cpu_generic_new()
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 3/4] hw/arm/integrator: Use new cpu_generic_new() |
Date: |
Mon, 13 Feb 2017 14:28:18 +0000 |
Use the new cpu_generic_new() function rather than doing the
work of creating it and calling parse_features by hand.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/arm/integratorcp.c | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c
index 5610ffc..beffaf4 100644
--- a/hw/arm/integratorcp.c
+++ b/hw/arm/integratorcp.c
@@ -577,42 +577,24 @@ static void integratorcp_init(MachineState *machine)
const char *kernel_filename = machine->kernel_filename;
const char *kernel_cmdline = machine->kernel_cmdline;
const char *initrd_filename = machine->initrd_filename;
- char **cpustr;
- ObjectClass *cpu_oc;
- CPUClass *cc;
Object *cpuobj;
ARMCPU *cpu;
- const char *typename;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
MemoryRegion *ram_alias = g_new(MemoryRegion, 1);
qemu_irq pic[32];
DeviceState *dev, *sic, *icp;
int i;
- Error *err = NULL;
if (!cpu_model) {
cpu_model = "arm926";
}
- cpustr = g_strsplit(cpu_model, ",", 2);
-
- cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, cpustr[0]);
- if (!cpu_oc) {
+ cpuobj = OBJECT(cpu_generic_new(TYPE_ARM_CPU, cpu_model));
+ if (!cpuobj) {
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
}
- typename = object_class_get_name(cpu_oc);
-
- cc = CPU_CLASS(cpu_oc);
- cc->parse_features(typename, cpustr[1], &err);
- g_strfreev(cpustr);
- if (err) {
- error_report_err(err);
- exit(1);
- }
-
- cpuobj = object_new(typename);
/* By default ARM1176 CPUs have EL3 enabled. This board does not
* currently support EL3 so the CPU EL3 property is disabled before
--
2.7.4
- [Qemu-devel] [PATCH 0/4] cpu: Implement cpu_generic_new(), Peter Maydell, 2017/02/13
- [Qemu-devel] [PATCH 2/4] cpu: Clarify TODO comment in cpu_generic_new(), Peter Maydell, 2017/02/13
- [Qemu-devel] [PATCH 1/4] cpu: add cpu_generic_new(), Peter Maydell, 2017/02/13
- [Qemu-devel] [PATCH 4/4] hw/arm/virt: Use new cpu_generic_new(), Peter Maydell, 2017/02/13
- [Qemu-devel] [PATCH 3/4] hw/arm/integrator: Use new cpu_generic_new(),
Peter Maydell <=
- Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] cpu: Implement cpu_generic_new(), Peter Maydell, 2017/02/16
- Re: [Qemu-devel] [PATCH 0/4] cpu: Implement cpu_generic_new(), Igor Mammedov, 2017/02/17