[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qem
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends |
Date: |
Tue, 14 Feb 2017 15:32:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> Fixes the following documentation bugs:
>
> * Fails to document that null @nptr is safe.
>
> * Fails to document that we return -EINVAL when no conversion could be
> performed (commit 47d4be1).
>
> * Confuses long long with int64_t, and unsigned long long with
> uint64_t.
>
> * Claims the unsigned conversions can underflow. They can't.
>
> While there, mark problematic assumptions that int64_t is long long,
> and uint64_t is unsigned long long with FIXME comments.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> util/cutils.c | 80
> +++++++++++++++++++++++++++++++++--------------------------
> 1 file changed, 45 insertions(+), 35 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/24] QemuOpts util/cutils: Fix and clean up number conversions, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() invalid input, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 19/24] tests/test-cutils: Drop suffix from test_qemu_strtosz_simple(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 14/24] util/cutils: New qemu_strtosz_metric(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 18/24] tests/test-cutils: Use qemu_strtosz() more often, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 12/24] tests/test-cutils: Cover qemu_strtosz() with trailing crap, Markus Armbruster, 2017/02/14