[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull() |
Date: |
Tue, 14 Feb 2017 15:34:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> The name qemu_strtoll() suggests conversion to long long, but it
> actually converts to int64_t. Rename to qemu_strtoi64().
>
> The name qemu_strtoull() suggests conversion to unsigned long long,
> but it actually converts to uint64_t. Rename to qemu_strtou64().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/qemu/cutils.h | 6 +-
> qobject/qdict.c | 2 +-
> qtest.c | 34 ++---
> tests/test-cutils.c | 366
> +++++++++++++++++++++++++++-----------------------
> util/cutils.c | 4 +-
> util/log.c | 4 +-
> 6 files changed, 224 insertions(+), 192 deletions(-)
Thankfully, not too many existing clients (except in the testsuite).
Mechanical search-and-replace, and I don't see anything missed, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi(), (continued)
- [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 10/24] tests/test-cutils: Add missing qemu_strtosz()... endptr checks, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 09/24] QemuOpts: Fix to reject numbers that overflow uint64_t, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit, Markus Armbruster, 2017/02/14