[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove pe
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent |
Date: |
Tue, 14 Feb 2017 19:29:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote:
> Remove persistent bitmap from the storage on block-dirty-bitmap-remove.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index c41b791..a365cdf 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2767,6 +2767,7 @@ void qmp_block_dirty_bitmap_remove(const char *node,
> const char *name,
> AioContext *aio_context;
> BlockDriverState *bs;
> BdrvDirtyBitmap *bitmap;
> + Error *local_err = NULL;
>
> bitmap = block_dirty_bitmap_lookup(node, name, &bs, &aio_context, errp);
> if (!bitmap || !bs) {
> @@ -2779,6 +2780,15 @@ void qmp_block_dirty_bitmap_remove(const char *node,
> const char *name,
> name);
> goto out;
> }
> +
> + if (bdrv_dirty_bitmap_get_persistance(bitmap)) {
> + bdrv_remove_persistent_dirty_bitmap(bs, name, &local_err);
> + if (local_err != NULL) {
> + error_propagate(errp, local_err);
> + goto out;
> + }
> + }
> +
> bdrv_dirty_bitmap_make_anon(bitmap);
> bdrv_release_dirty_bitmap(bs, bitmap);
>
>
Reviewed-by: John Snow <address@hidden>
- [Qemu-devel] [PATCH v14 00/24] qcow2: persistent dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 19/25] iotests: test qcow2 persistent dirty bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 12/25] block/dirty-bitmap: add bdrv_dirty_bitmap_next(), Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 17/25] qmp: add autoload parameter to block-dirty-bitmap-add, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent, Vladimir Sementsov-Ogievskiy, 2017/02/14
- Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent,
John Snow <=
- [Qemu-devel] [PATCH 05/25] block: fix bdrv_dirty_bitmap_granularity signature, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 06/25] block/dirty-bitmap: add deserialize_ones func, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 14/25] block: add bdrv_can_store_new_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 04/25] tests: add hbitmap iter test, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 07/25] qcow2: add bitmaps extension, Vladimir Sementsov-Ogievskiy, 2017/02/14
- [Qemu-devel] [PATCH 18/25] qmp: add x-debug-block-dirty-bitmap-sha256, Vladimir Sementsov-Ogievskiy, 2017/02/14